chore: update-discriminator-mapping #2280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Wamae
requested review from
irvinesunday,
darrelmiller,
gavinbarron,
millicentachieng,
MaggieKimani1,
andrueastman and
baywet
as code owners
baywet
requested changes
Mar 24, 2025
src/Microsoft.OpenApi/Reader/V31/OpenApiDiscriminatorDeserializer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.OpenApi.Readers.Tests/V31Tests/Samples/OpenApiDocument/docWithExample.yaml
Outdated
Show resolved
Hide resolved
src/Microsoft.OpenApi/Reader/V3/OpenApiDiscriminatorDeserializer.cs
Outdated
Show resolved
Hide resolved
...Microsoft.OpenApi.Readers.Tests/V3Tests/Samples/OpenApiDiscriminator/basicDiscriminator.yaml
Outdated
Show resolved
Hide resolved
baywet
reviewed
Mar 26, 2025
test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiDiscriminatorTests.cs
Show resolved
Hide resolved
|
baywet
reviewed
Mar 28, 2025
| @@ -38,6 +38,7 @@ public async Task ParseBasicDiscriminatorShouldSucceed() | |||
| Mapping = | |||
| { | |||
| ["puppy"] = new OpenApiSchemaReference("Dog", openApiDocument), | |||
| ["kitten"] = new OpenApiSchemaReference("Cat" , openApiDocument, "Cat"), | |||
There was a problem hiding this comment.
Suggested change
| ["kitten"] = new OpenApiSchemaReference("Cat" , openApiDocument, "Cat"), | |
| ["kitten"] = new OpenApiSchemaReference("Cat" , openApiDocument, "https://gigantic-server.com/schemas/animals.json"), |
Sorry, this is what I meant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2140